Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A preview on Cerberus 2 #431

Closed
wants to merge 16 commits into from
Closed

Conversation

funkyfuture
Copy link
Member

i thought it might be a good idea to present what i have done so far for Cerberus 2.

any questions and critique is welcome, reviewing per commit is certainly to be recommended.

don't merge this, it is wip, it will be rewritten

In order to use literal type annotations, support for CPython 3.4 was
removed which will be end-of-life before CPython 2.7.
Copy link

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see some progress - cerberus is pretty cool and I'm using it extensively on a project. I even have a validation schema that validates the input is a cerberus validation schema...

.travis.yml Show resolved Hide resolved
cerberus/__init__.py Show resolved Hide resolved
UPGRADING.rst Show resolved Hide resolved
@eirnym
Copy link

eirnym commented Apr 29, 2019

Could you fix merge conflicts?

@funkyfuture
Copy link
Member Author

@eirnym this will happen once 1.3 is released (and thus the feature freeze is in effect) and i find the time to rebase or to rewrite, it's not a trivial task. also, i want to open a discussion on the question of the extent of type annotations.

what is your particular interest to ask for an update? maybe there's another way to serve that.

@eirnym
Copy link

eirnym commented Apr 29, 2019

I'd like to help you with as many changes there make sense. Also I'd like to see a few additional features asked here and there like "user documentation" for each element inside the schema itself and checking a schema object.

Currently, I remove doc keys to pass them forward and checking a schema object by checking a dummy document.

Also I want to try to find out if it's hard to merge the new version without rebasing and breaking anything.

This library is quite sensitive for my work, so I have a motivation to support it.

@eirnym
Copy link

eirnym commented Apr 29, 2019

I opened a pull request to your branch with the merge, please, verify it.

@funkyfuture
Copy link
Member Author

Also I'd like to see a few additional features asked here and there like "user documentation" for each element inside the schema itself and checking a schema object.

please open separate issues for each proposal.

Also I want to try to find out if it's hard to merge the new version without rebasing and breaking anything.

i certainly won't hinder you from giving it a shot.

having that said, i don't think the type annotations will sustain in the extent as i did here. but they can also be (partly) removed later.

This library is quite sensitive for my work, so I have a motivation to support it.

everyone is welcome. i'd have to review all the planning to give some practical advice what should be addressed in what order. maybe you could look through the items in the ROADMAP.md and post in the corresponing issues that you would like to work on.

@funkyfuture funkyfuture mentioned this pull request May 2, 2019
@funkyfuture
Copy link
Member Author

Closing in favor of #497.

@funkyfuture funkyfuture closed this Jun 7, 2019
@funkyfuture funkyfuture deleted the forward branch January 28, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants