-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A preview on Cerberus 2 #431
Conversation
cb71e96
to
531c313
Compare
In order to use literal type annotations, support for CPython 3.4 was removed which will be end-of-life before CPython 2.7.
Yippie, that makes the code more lightweight and much easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see some progress - cerberus is pretty cool and I'm using it extensively on a project. I even have a validation schema that validates the input is a cerberus validation schema...
Could you fix merge conflicts? |
@eirnym this will happen once 1.3 is released (and thus the feature freeze is in effect) and i find the time to rebase or to rewrite, it's not a trivial task. also, i want to open a discussion on the question of the extent of type annotations. what is your particular interest to ask for an update? maybe there's another way to serve that. |
I'd like to help you with as many changes there make sense. Also I'd like to see a few additional features asked here and there like "user documentation" for each element inside the schema itself and checking a schema object. Currently, I remove Also I want to try to find out if it's hard to merge the new version without rebasing and breaking anything. This library is quite sensitive for my work, so I have a motivation to support it. |
I opened a pull request to your branch with the merge, please, verify it. |
please open separate issues for each proposal.
i certainly won't hinder you from giving it a shot. having that said, i don't think the type annotations will sustain in the extent as i did here. but they can also be (partly) removed later.
everyone is welcome. i'd have to review all the planning to give some practical advice what should be addressed in what order. maybe you could look through the items in the |
Closing in favor of #497. |
i thought it might be a good idea to present what i have done so far for Cerberus 2.
any questions and critique is welcome, reviewing per commit is certainly to be recommended.
don't merge this, it is wip, it will be rewritten